Skip to content

Conversation

@v-tarasevich-blitz-brain
Copy link
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain commented Oct 13, 2025

This PR forcibly disables documentationFileUploadV1 when S3 isn't configured

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Oct 13, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Oct 13, 2025

🔴 Meticulous spotted visual differences in 2 of 1093 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 909e504. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--ch-836-upsert-link--enable-feature-flag-only-when-s3-is-set-up branch from 2ee1ab7 to f47f971 Compare October 13, 2025 15:15
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain marked this pull request as ready for review October 14, 2025 09:49
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 14, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--ch-836-upsert-link--enable-feature-flag-only-when-s3-is-set-up branch from f47f971 to 909e504 Compare October 20, 2025 15:58
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain changed the title feat(uploadFiles): disable feature flag when bucket name was not provided feat(uploadFiles): disable feature flag when s3 isn't configured Oct 20, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Oct 21, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--ch-836-upsert-link--enable-feature-flag-only-when-s3-is-set-up branch from 22cfdf0 to ceb4416 Compare October 22, 2025 08:35
@chriscollins3456 chriscollins3456 merged commit afdf18e into master Oct 22, 2025
40 checks passed
@chriscollins3456 chriscollins3456 deleted the vt--ch-836-upsert-link--enable-feature-flag-only-when-s3-is-set-up branch October 22, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants